[NextJS] REST Layout service ip resolving #1578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
added
the
backlog
|
@mathijs-b2m Thanks for your report and contribution! I've created a ticket with all the details in our internal backlog to review and merge PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve GeoIP / tracking issues when using REST Layout Service together with next application running in containerized environment.
Description / Motivation
When the REST Layout service is called from the Next application, when running containerized (instead of Vercel or other SWA environments) the x-forwarded-ip header should be forwarded instead of the socket remote address which can belong to a load balancer. Also replaced connection for socket as its deprecated since v16.
Testing Details
The solution should still be tested on other environments so it does not break functionality there.
Types of changes